[Webkit-unassigned] [Bug 16815] Crash with navigator.plugins and navigator.mimeTypes after plugins.refresh

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16815





------- Comment #32 from hausmann at kde.org  2008-03-07 08:32 PDT -------
Some comments on the latest changes that go beyond the smaller fixes:

1) The reference counting was indeed incorrect and WebCore::PluginData was
accidentially also not using the create()/adoptRef() pattern. This is fixed
now.

2) The forward declaration of the toJS function we included because
JSPlugin.cpp's indexGetter() function calls item in WebCore::Plugin. That
function returns a MimeType pointer which needs to be converted to a JSValue
using the toJS function generated in JSMimeType.h. So JSPlugin.cpp needs to
include JSMimeType.h due to the indexGetter. We could not find a way to add
this inclusion so a plain forward declaration seemed like the easiest fix.

3) I agree about the use of a constructor for MimeClassInfo, but then I'm not
sure how important the performance is here since this is normally called only
once on startup. On the other hand I find code that initializes the members by
name more readable than passing just arguments to the constructor.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.