[Webkit-unassigned] [Bug 17674] <hr> appears gray instead of green because of color attribute is defined followed by noshade attribute

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17674


webkit at blaut.biz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|<hr> appears gray instead of|<hr> appears gray instead of
                   |green because of noshade    |green because of color
                   |property                    |attribute is defined
                   |                            |followed by noshade
                   |                            |attribute




------- Comment #4 from webkit at blaut.biz  2008-03-05 05:58 PDT -------
After digging into HTMLHRElement.cpp 

} else if (attr->name() == colorAttr) {
        addCSSProperty(attr, CSS_PROP_BORDER_TOP_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_RIGHT_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_BOTTOM_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_LEFT_STYLE, CSS_VAL_SOLID);
        addCSSColor(attr, CSS_PROP_BORDER_COLOR, attr->value());
        addCSSColor(attr, CSS_PROP_BACKGROUND_COLOR, attr->value());
    } else if (attr->name() == noshadeAttr) {
        addCSSProperty(attr, CSS_PROP_BORDER_TOP_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_RIGHT_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_BOTTOM_STYLE, CSS_VAL_SOLID);
        addCSSProperty(attr, CSS_PROP_BORDER_LEFT_STYLE, CSS_VAL_SOLID);
        addCSSColor(attr, CSS_PROP_BORDER_COLOR, String("grey"));
        addCSSColor(attr, CSS_PROP_BACKGROUND_COLOR, String("grey"));


I found that the problem will disappear if you define: <hr noshade
color="red">. The construction <hr color="red" noshade> is buggy

It seems the bug is easy to fix.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.