[Webkit-unassigned] [Bug 17626] Programatically set background color and 16-bit alpha on WebKit GTK

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17626


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19469|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2008-03-02 19:08 PDT -------
(From update of attachment 19469)
+        g_value_set_uint(value,
webkit_web_view_get_background_alpha(webView));
     default:

Missing a break here. I'm going to set review- because of that. Otherwise looks
pretty good, but I'm not a GTK platform expert.

-        gboolean transparent;
+       GdkColor bg_color;
+       guint16 bg_alpha;
+       gboolean bg_color_set;

This indentation in the new code is done with tabs, and there's also a tab in
the ChangeLog entry. We can't check tabs into our repository, so please try to
avoid tabs while writing the patch to help the person committing it.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.