[Webkit-unassigned] [Bug 16898] REGRESSION: Text of entire page incorrectly center aligned

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16898


kevino at theolliviers.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19476|                            |review?
               Flag|                            |




------- Comment #7 from kevino at theolliviers.com  2008-03-01 18:10 PDT -------
Created an attachment (id=19476)
 --> (http://bugs.webkit.org/attachment.cgi?id=19476&action=view)
Fix for the problem that ignores rules with an invalid value

This is my first foray into CSSGrammar.y and Bison code, so I would really
appreciate some extra eyes on this fix. I'm not seeing any new layout test
failures after the change, but I don't know if there are any corner cases I'm
missing or if the approach might be overly general. 

Also, I assume we want a layout test created for this, so that the regression
won't recur later on? Where should I put it? And do we need to generate results
on all platforms for it? (New to writing LayoutTests too, sorry... ;-)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.