[Webkit-unassigned] [Bug 19819] New: WebKit history API crashing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19819

           Summary: WebKit history API crashing.
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: xan.lopez at gmail.com


Just found it, but it seems to not be working at all. At the very least we
should commit this:

diff --git a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
index f1734d3..b98f467 100644
--- a/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
+++ b/WebKit/gtk/webkit/webkitwebhistoryitem.cpp
@@ -363,6 +363,7 @@ const gchar*
webkit_web_history_item_get_alternate_title(WebKitWebHistoryItem* w
 void webkit_web_history_item_set_alternate_title(WebKitWebHistoryItem*
webHistoryItem, const gchar* ti
 {
     g_return_if_fail(WEBKIT_IS_WEB_HISTORY_ITEM(webHistoryItem));
+    g_return_if_fail(title != NULL);

     WebCore::HistoryItem* item = core(webHistoryItem);


to avoid the crasher (and also a good thing to have in general).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.