[Webkit-unassigned] [Bug 19130] [GTK] ChromeClient::createWindow and friends need to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19130





------- Comment #21 from christian at imendio.com  2008-06-25 05:40 PDT -------
(In reply to comment #20)
> (In reply to comment #17)
> > Created an attachment (id=21902)
 --> (https://bugs.webkit.org/attachment.cgi?id=21902&action=view) [edit]
> > proposed patch
> 
> The return value of show-web-view should be a boolean but when creating the new
> signal WEBKIT_TYPE_WEB_VIEW is used. This also explain Christian's problem.

Good catch. You mentioned return types earlier but I didn't double check that
on the last version of the patch.

Another question came to my mind: when testing create-web-view I did not use
show-web-view as suggested by the documentation. For instance to add a tab to a
GtkNotebook the widget needs to be visible due to a quirk in the
implementation. So the widget is visible immediately. This is probably
different if the new web view is contained in a newly created window. Further
more, there is no indication of the expected time frame between creating and
showing the new web view - I can't leave the new widget invisible for a
possibly long time, otherwise the application looks broken. This needs to be
clearly documented, otherwise it might better to discard that second step
altogether.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.