[Webkit-unassigned] [Bug 19357] [GTK] Loading of resource images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19357





------- Comment #7 from christian at imendio.com  2008-06-24 13:10 PDT -------
(In reply to comment #5)
> (In reply to comment #4)
> >    - You want to handle "missingImage", "nullPlugin", "urlIcon",
> > "textAreaResizeCorner".
> 
> For missingImage we want for sure to use the GTK icon. The other icons are
> probably less important as they are less common, so maybe we can add them in a
> second time.
> 
> Do you know when urlIcon and textAreaResizeCorner are used? I wasn't able to
> figure that out reading the code.

I suspect textAreaResizeCorner is the resize grip on the bottom right of text
areas that you typically see in applications as soon as scrollbars appear. In
our case it's always visible if text areas can be resized.
Instead of using an icon WebKit needs to draw it with gtk_paint_resize_grip.

> >    - You certainly don't want to use missingImage for nullPlugin
> 
> Isn't it still better than nothing?

I tend to agree with 'anything would be good for now' but that always bares the
danger of leaving the problem persist in trunk for even longer.

> >    - The tricky part where I lack an answer is if we want to install the webkit
> > icons for the above somewhere? Should we embed them in the code? Does the fdo
> > icon theme spec have some icons we could reuse?
> 
> Probably yes for the urlIcon but I don't know when it's used so I don't know
> what is the best icon for that.
> 
> The spec doesn't have anything for missingPlugin (and neither something for
> plugins in general). I already talked with some tango icon designers about
> this, probably the best thing is to get a plugin icon in the spec and use that.
> I will open a bug on fd.o but probably it will take time, so maybe it's better
> to ship an icon with WebKit for now.

There is no choice. If there is no standard icon, it needs to be shipped, be it
in the spec or not. There is no way we can rely on one theme that gains the
icon two days before the patch is committed.
We can safely try to get hold of someone who makes the missing icons, install
them a private folder, such as $prefix/share/webkit and switch to something
else later.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.