[Webkit-unassigned] [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19727





------- Comment #13 from jonathon.jongsma at collabora.co.uk  2008-06-23 19:30 PDT -------
(In reply to comment #12)
> (From update of attachment 21891 [edit])
> Please don't check in your ChangeLog with:
> 
>          WARNING: NO TEST CASES ADDED OR CHANGED

Sorry, just to clarify, are you saying that I should delete this line before
attaching a patch to bugzilla?  I usually leave that in when I don't have tests
just to make it obvious to the reviewer that there are no tests with this
patch.  But I can remove it from future patches if you'd like.  On the other
hand, if by 'check in', you meant 'commit to svn', then I'm afraid I don't have
commit access yet.

> Please add an entry to the ChangeLog with the bug number in it and a summary
> description of the changes.

Good point, I will try to remember to do so in the future.  Or I can upload a
modified patch if it would be helpful.  


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.