[Webkit-unassigned] [Bug 19727] Add GraphicsContext::hasShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 11:13:52 PDT 2008


------- Comment #5 from jonathon.jongsma at collabora.co.uk  2008-06-23 11:13 PDT -------
(In reply to comment #4)
> (From update of attachment 21884 [edit])
> This function will return false for a 0-offset, positive-blur shadow. At the
> very least, this makes the name "hasShadow()" misleading.

Good point, but I think you've found a bug rather and this function should
probably return true for this case since it indicates that the backend should
draw something (In this case, the cairo backend would draw a shadow that is
completely obscured since it doesn't yet support blur, but I don't see a big
problem with that since I'd assume that it will get blur support eventually). 
To me, this indicates why it would be beneficial to separate the logic into a
function like this -- a bug in the logic only needs to be fixed once rather
than several places.  

I like darin's suggestion of returning a bool for getShadow.  I'll attach an
updated patch with that change (and check for non-zero alpha and blur values)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list