[Webkit-unassigned] [Bug 19727] Add GraphicsContext::hasShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 10:21:54 PDT 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #21884|review?                     |review+
               Flag|                            |

------- Comment #3 from darin at apple.com  2008-06-23 10:21 PDT -------
(From update of attachment 21884)
I think a better way to do this would be to make the getShadow function return
a boolean, so you can easily check if you can entirely skip the shadow drawing
while getting the specification for drawing it if you do need to.

You can see this would work because the calls to hasShadow both have calls to
getShadow immediately afterward.

+    return m_common->state.shadowColor.isValid() &&
+        (m_common->state.shadowSize.width() ||
+         m_common->state.shadowSize.height());

This should also check shadowColor.alpha() for a non-zero value.

I'm going to say r=me, but I think it would be better to do this without adding
a new function.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list