[Webkit-unassigned] [Bug 18987] [GTK] Implement SharedBuffer::createWithContentsOfFile and KURL::fileSystemPath

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18987


freyther at handhelds.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21080|review?                     |review-
               Flag|                            |




------- Comment #6 from freyther at handhelds.org  2008-06-23 09:31 PDT -------
(From update of attachment 21080)
Sorry, I have to say r=- on this one. I will be on irc tomorrow we can resolve
this and land the patch without waiting another month.

comments:
   - the goto is unusual, we tend to use early exits
   - KURL::fileSystemPath does not work with utf8 encoded paths as String
path(char*) works only on latin1.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.