[Webkit-unassigned] [Bug 19727] New: Add GraphicsContext::hasShadow() so the tests aren't duplicated so many times in Cairo and Qt ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19727

           Summary: Add GraphicsContext::hasShadow() so the tests aren't
                    duplicated so many times in Cairo and Qt ports
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jonathon.jongsma at collabora.co.uk
                CC: hausmann at webkit.org


The Cairo and Qt ports dont' support platform shadows, so text shadows are
drawn 'manually'.  Before drawing the shadows, they perform a test to see if
there is a valid shadow, e.g.:
bool hasShadow = textDrawingMode() == cTextFill && shadowColor.isValid() &&
(shadowSize.width() || shadowSize.height());

This test must be replicated anywhere we draw something that should have a
shadow (e.g. text, underlines, etc).  Instead of copying and pasting this test
every time, it would be nice to have a convenience function such as
GraphicsContext::hasShadow() that could tell us whether a shadow should be
drawn or not.

(Suggested in Bug #18459)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.