[Webkit-unassigned] [Bug 9214] Images using QT plugin do not display correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=9214





------- Comment #8 from ddkilzer at webkit.org  2008-06-22 14:09 PDT -------
(In reply to comment #7)
> Created an attachment (id=21875)
 --> (https://bugs.webkit.org/attachment.cgi?id=21875&action=view) [edit]
> Patch v1
> 
> Proposed patch.
> 
> HTMLEmbedObject::isImageType() was copied directly from HTMLObjectElement. 
> Should I create a base class for HTMLEmbedElement and HTMLObjectElement, or
> move common methods to HTMLPlugInElement?    Note that HTMLAppletElement also
> inherits from HTMLPlugInElement, which wouldn't used some member variables or
> methods.
> 
> (The changes to HTMLObjectElement were to make extracting member variables and
> methods to a base class easier.)

- Not sure if code in WebCore/rendering/HitTestResult.cpp is needed.  (Note
sure when the objectTag code is used.)

- Is there a better place for the data: URL parsing other than the
isImageType() method(s) in HTMLEmbedElement and HTMLObjectElement classes?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.