[Webkit-unassigned] [Bug 19542] Crash in Font::glyphDataForCharacter when getting small caps data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19542


marv.decker at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21842|                            |review?
               Flag|                            |




------- Comment #5 from marv.decker at gmail.com  2008-06-19 11:01 PDT -------
Created an attachment (id=21842)
 --> (https://bugs.webkit.org/attachment.cgi?id=21842&action=view)
Patch

This patch just adds a NULL check for the page() of glyphs like the rest of the
file. If this fails, it does the same thing it would do if the GlyphData in the
page is NULL.

I did not add a test. This patch is based on a crash report I saw. The stack is
clear that the crash is dereferencing a NULL from the page() here, but I can
not reproduce, even opening the page that triggered the crash report. I also
tried to generate some small caps text in a funny language that wouldn't be in
the font, but I could not trigger it. It is probably highly dependent on the
WebKit port, OS, and installed fonts. If you have an idea for a test, I'll be
happy to write it.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.