[Webkit-unassigned] [Bug 19652] [CAIRO] wrong drawing of border-image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19652


vbs85 at gmx.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vbs85 at gmx.de




------- Comment #5 from vbs85 at gmx.de  2008-06-19 00:57 PDT -------
(In reply to comment #4)
> (From update of attachment 21823 [edit])
> This call to cairo_destroy can pass an uninitialized value for cr_surface which
> I doubt is safe:
> 
> +    cairo_destroy(cr_surface);
> 
> Why does the call to cairo_destroy need to be outside the body of the if block
> where cr_surface is used?

cairo_destroy decreases the reference count. And every acces to image (where
the new surface is stored at the end) caused crashes of webkit.

> The naming of cr_surface seems like poor choice too
rigth. How about:
surface -> clippedImage
cr_surface -> clippedImageContext
?


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.