[Webkit-unassigned] [Bug 19546] [Gtk] Crasher when using file:// protocol

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19546





------- Comment #2 from jmalonzo at gmail.com  2008-06-15 02:01 PDT -------
Following is a fix from Alp (http://paste.lisp.org/display/61072). If you know
GIO, please let us know if the fix is correct.

Index: WebCore/platform/network/soup/ResourceHandleSoup.cpp
===================================================================
--- WebCore/platform/network/soup/ResourceHandleSoup.cpp        (revision
33954)
+++ WebCore/platform/network/soup/ResourceHandleSoup.cpp        (working copy)
@@ -412,9 +412,11 @@
 {
     ResourceHandle* handle = static_cast<ResourceHandle*>(data);
     ResourceHandleInternal* d = handle->getInternal();
+    ResourceHandleClient* client = handle->client();

     g_input_stream_close_finish(d->m_input_stream, res, NULL);
     cleanupGioOperation(handle);
+    client->didFinishLoading(handle);
 }

 static void readCallback(GObject* source, GAsyncResult* res, gpointer data)
@@ -438,7 +440,6 @@
         client->didFinishLoading(handle);
         return;
     } else if (!nread) {
-        client->didFinishLoading(handle);
         g_input_stream_close_async(d->m_input_stream, G_PRIORITY_DEFAULT,
                                    NULL, closeCallback, handle);
         return;


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.