[Webkit-unassigned] [Bug 19470] Null pointer dereferences on a document with no documentElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19470


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21691|review?                     |review-
               Flag|                            |




------- Comment #8 from darin at apple.com  2008-06-14 01:02 PDT -------
(From update of attachment 21691)
+  if (window.LayoutTestController)
+    window.LayoutTestController.dumpAsText();

The letter "L" has to be lowercase here, or it won't work.

Added: svn:eol-style
   + LF

Why LF style? We don't use that style for other files.

+            if (const Element* doc = static_cast<const
Document*>(this)->documentElement())
+                return doc->isDefaultNamespace(namespaceURI);

We normally use "doc" for "document". Using "doc" for "documentElement" is
unnecessarily confusing. Maybe "de" or "documentElement" or even just "e" or
"element". Also really no need for const in the type of the local variable.

review- because of the letter "L" problem. I have no idea why the test worked!

Do you really want to go without a name in the change log? I'd prefer
"Anonymous" to "danceoff" for the name here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.