[Webkit-unassigned] [Bug 19457] Create fused opcodes for tests and conditional jumps

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 11:57:40 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=19457


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21613|review?                     |review+
               Flag|                            |




------- Comment #3 from darin at apple.com  2008-06-11 11:57 PDT -------
(From update of attachment 21613)
 395 void CodeGenerator::retrieveLastBinaryOp(int& dstIndex, int& src1Index,
int& src2Index)
 396 {
 397     size_t size = instructions().size();
 398     dstIndex = instructions().at(size - 3).u.operand;
 399     src1Index = instructions().at(size - 2).u.operand;
 400     src2Index = instructions().at(size - 1).u.operand;
 401 }

This should assert that size is >= 4.

 405     instructions().shrink(instructions().size() - 4);

 403 void CodeGenerator::rewindBinaryOp()
 404 {
 405     instructions().shrink(instructions().size() - 4);
 406 }

This too.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list