[Webkit-unassigned] [Bug 19422] Distinct redirects from the same link do not create distinct history items

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 01:39:37 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19422





------- Comment #1 from cwzwarich at uwaterloo.ca  2008-06-10 01:39 PDT -------
The problem is that shouldTreatURLAsSameAsCurrent() is saying that the "random
comic" link is the same as the current link. The check in
shouldTreatURLAsSameAsCurrent() is

    return url == m_currentHistoryItem->url() || url ==
m_currentHistoryItem->originalURL();

If I remove the second part of this test, then the bug is fixed, with two
caveats:

1) There is a back/forward history item, but no item in the history item.

2) If I click the link while it is redirecting, it seems I can make URLs appear
in the history of the form "http://cantandgirl.com./..." with a period after
".com". The URL works, but I am pretty sure it isn't the URL being given by the
server.

The check has been there at least since revision 2963:

http://trac.webkit.org/changeset/2963

If no one responds with a reason why this change is obviously a bad idea, I
will just submit a patch with test cases for review.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list