[Webkit-unassigned] [Bug 15914] [GTK] Implement Unicode functionality using GLib

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=15914


dominik.roettsches at access-company.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominik.roettsches at access-
                   |                            |company.com




------- Comment #8 from dominik.roettsches at access-company.com  2008-06-09 08:13 PDT -------
In r33380 (http://trac.webkit.org/changeset/33380) the appendOmittingBOM
function was removed. So this patch can't be cleanly applied to tip of trunk
currently (appendOmittingBOM is used for example in TextCodecGtk::decode()).
The solution I came up with so far was to explicitly specify UTF-16LE as the
target encoding in g_iconv_open() of TextCodecGtk::createIConvDecoder().
Currently I only used LE, but Glib's byte-order macros could be used to
determine the correct target encoding including its byte order at compile time.

This stops libiconv from generating BOMs for the result of the conversion.
Consequently, there's no need for removing the BOMs when appending them to the
Vector<UChar>, allowing us to just use result.append(buffer, count /
sizeof(UChar)). 

What is your opinion on this approach? Do you think that's the right direction
to go or do you see any risks? 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.