[Webkit-unassigned] [Bug 19402] Dynamic javascript-based layout changes do not render properly

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=19402


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |hyatt at apple.com




------- Comment #6 from mitz at webkit.org  2008-06-06 19:51 PDT -------
(In reply to comment #5)
> (From update of attachment 21518 [edit])
> Is there a way to do this without replacing a single function call with four?

Yes. By calling setNeedsLayout(false) and setPrefWidthsDirty(false) before
calling setNeedsLayoutAndPrefWidthsRecalc(). That'd be adding just two function
calls. Another option is to add a parameter to the "dirtying" function to force
unconditional marking. Yet another option is to patch <select>s to make sure
they don't dirty themselves when they don't have a parent, but maybe the
problem is not limited to <select>s.

> Is there something we can do to avoid making this type of mistake in the
> future?

I don't know. I'd like to hear what Hyatt thinks about this bug and the
proposed patch.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.