[Webkit-unassigned] [Bug 19417] New: CSSParser should use custom "vector-like" class for managing properties

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=19417

           Summary: CSSParser should use custom "vector-like" class for
                    managing properties
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: hyatt at apple.com, darin at apple.com, sam at webkit.org


CSSParser should use custom "vector-like" class for managing properties

Right now CSSParser has this ad hoc system of m_parsedProperties
m_numParsedProperties and m_maxParsedProperties, along with a bunch of
fastMalloc and fastRealloc statements.  We can't just replace this directly
with a vector (unless we're comfortable changing away from the current
allocation scheme.  But we should at least move to a custom class which
encapulates this logic.  That would make parts of CSSParser much cleaner (no
more direct array lookups, instead we would call things like

m_parseProperties.last(), etc.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.