[Webkit-unassigned] [Bug 18510] Text controls only emit the start editing signal after the first keypress

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 6 05:23:15 PDT 2008


------- Comment #6 from iain at openedhand.com  2008-06-06 05:23 PDT -------

> The indentation of the code looks wrong, and part of the patch is only this
> indentation change on some existing code.

Ah, yes, I had emacs in indent tab mode, but WebKit uses spaces to indent.

> As with any WebKit bug fix, the patch needs to include a regression test that
> demonstrates the problem. And a ChangeLog entry.

The new patch includes a ChangeLog entry and fixes all your comments above.

I'm not entirely sure where regression tests go, and to be honest I'm not sure
how one would go about writing an automated test for what is more a change of
behaviour rather than a bug per say. But maybe if I see what the other
regression tests look like I'll have an epiphany.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list