[Webkit-unassigned] [Bug 19403] ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 21:32:18 PDT 2008


eric at webkit.org changed:

           What    |Removed                     |Added
  Attachment #21519|review?                     |review+
               Flag|                            |

------- Comment #3 from eric at webkit.org  2008-06-05 21:32 PDT -------
(From update of attachment 21519)
Looks good.  The if (string.isEmpty()) should have a comment before it
explaning "why", since I'm not sure it will be clear to either of us why it's
there in 9 months. :)

If you strongly disagree I'm fine w/ you to landing w/o comment.  I don't need
to see your final patch again either way. :)

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list