[Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20013





------- Comment #36 from sankaraditya+bugzilla at gmail.com  2008-07-31 11:07 PDT -------
I have checked in Firefox. 
<i style="display: block;">Test.</i> 

Though <i> tag is displayed in block fashion, Firefox ignores it. Firefox just
considers the text content of <i> tag. I think, webkit should follow that 
behavior as displayed in Firefox.

~ Thanks.

(In reply to comment #27)
> Testing whether an object can be ignored by checking the tag name does not seem
> to work well.
> 
> This should be present in the tree as a button:
> <i role="button">Test.</i>
> 
> This should be present as a container:
> <i style="display: block;">Test.</i>
> 
> This should be present as a list item:
> <i style="display: list-item;">Test.</i>
> 
> This can be ignored:
> <i>Test.</i>
> 
> This is how these objects are presented by Firefox 3. However, with this patch,
> the accessibility of the <i> tag is ignored in all of these cases.
> 
> Smaller issues:
> +    if(m_renderer->isListItem())
> +        return ListItemRole;
> +
> +    if(m_renderer->isHR())
> +        return SeparatorRole;
> +
> +    if(isListElement(node))
> +        return ListRole;
> +
> Need spaces between if and (.
> 
> +        case WebCore::DocumentRole:
> +          return ROLE_SYSTEM_DOCUMENT;
> +        case WebCore::CellRole:
> +          return ROLE_SYSTEM_CELL;
> +        case WebCore::ListItemRole:
> +          return ROLE_SYSTEM_LISTITEM;
> +        case WebCore::SeparatorRole:
> +          return ROLE_SYSTEM_SEPARATOR;
> Needs two more spaces of indentation before each return.
> 
> 
> As Sam and Mark said, this still needs to be broken down; the patch tries to
> fix issues with list items, tables, links, images, inline elements, text
> elements, separators, and documents, when each of these is a separate issue.
> 
> It would be best if you could submit a patch for each of these small items,
> along with a test.
> 
> I hope this doesn't put you off of working on this! :)
> 


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.