[Webkit-unassigned] [Bug 20224] Include the Writing Direction sub-menu in the context menu of the Qt port.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20224


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22550|review?                     |review-
               Flag|                            |




------- Comment #2 from hausmann at webkit.org  2008-07-31 06:14 PDT -------
(From update of attachment 22550)
I agree with the patch in principle, but I think the #ifdefs are not entirely
correct. Revision 34426 accidentially put the writing direction menu item into
a PLATFORM(MAC) block where previously it was effectively !PLATFORM(GTK).
Before the  change it was available on all platforms (mac, win, wx, qt, etc.)
except Gtk, now it's only available for the mac. Can you fix it that way around
using !PLATFORM(GTK) and refer to change 34426 in the change log?

Thanks :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.