[Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 29 13:47:24 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=20013
eric at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22470|review? |review+
Flag| |
------- Comment #21 from eric at webkit.org 2008-07-29 13:47 PDT -------
(From update of attachment 22470)
I still think that:
+ elementHashSet.add(bTag.toString());
probably don't need the explicit .toString() calls.
+ elementHashSet.add(bTag);
Should "just work". BUt maybe I'm wrong.
This:
+ String elementTitle = childrenVector[i]->title();
+ append(elementText, elementTitle);
Can be written:
+ append(elementText, childrenVector[i]->title());
Either way is fine. :)
Sad that we have to copy a string here:
+ return String::adopt(elementText).stripWhiteSpace();
But it should be fine.
No { } around single line if clauses:
+ if (m_renderer->isBlockFlow()) {
+ return m_renderer->isAnonymousBlock();
+ }
This change looks great to me! I'll ask Jon to look over it one more time.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list