[Webkit-unassigned] [Bug 18987] [GTK] Implement SharedBuffer::createWithContentsOfFile and KURL::fileSystemPath

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18987





------- Comment #8 from unavowed at vexillium.org  2008-07-28 04:50 PDT -------
(In reply to comment #7)
> (In reply to comment #6)
> > comments:
> >    - the goto is unusual, we tend to use early exits
> 
> The first version of the patch was based on the win port that uses gotos, when
> rewriting it to use g_file_get_contents() I din't change the structure of the
> code. I can fix it in the next version of the patch.
> 
> >    - KURL::fileSystemPath does not work with utf8 encoded paths as String
> > path(char*) works only on latin1.
> 
> What do you mean?
> 

I think he means you should use String::fromUTF8() in String
KURL::fileSystemPath(), instead of the normal String constructor.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.