[Webkit-unassigned] [Bug 16313] text search (find) keybindings should work in the Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16313


jalkut at red-sweater.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jalkut at red-sweater.com




------- Comment #3 from jalkut at red-sweater.com  2008-07-26 23:04 PDT -------
I stumbled on this bug because it was referenced in IRC. The only skepticism
that jumps to my mind is whether the "match" is too inclusive.  For instance,
this patch is intended to allow ctrl-F and cmd-F to perform a certain action,
but the code as written will (I think) allow many key combinations to perform
this action:

cmd-ctrl-F
cmd-shift-F
ctrl-shift-F
opt-ctrl-F

Etc.

I don't know enough about the code flow around this to know whether this
matters. But generally when keyboard shortcut modifiers are being explicitly
tested, it's important to confirm that the desired modifier is being pressed TO
THE EXCLUSION of the other modifier keys.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.