[Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20013





------- Comment #15 from eric at webkit.org  2008-07-24 01:58 PDT -------
(From update of attachment 22459)
Jon gave you plenty of comments already, but here is another:

+        elementHashSet.add(bTag.toString());

Those shouldn't need an explicit .toString() call:

 operator const String&() const { return m_string; }

Should make AtomicStrings transparently convert.  You should just be able to
do:

+        elementHashSet.add(subTag);

Of course this is all moot if you find out that you should be testing:

element->style()->display() == INLINE

instead.

And unfortunately this is not an unusual number of reviews for someone's first
patch to WebKit to go through.  Hopefully you don't find this process too
frustrating.  Large patches like this are difficult to do as one's "first
patch" :)  Especially since WebKit has a different style from so much other C++
code.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.