[Webkit-unassigned] [Bug 18608] [Gtk] WebKitNetworkRequest needs to be finished

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18608





------- Comment #11 from christian at imendio.com  2008-07-24 00:59 PDT -------
(In reply to comment #10)
> >struct _WebKitNetworkRequestPrivate {
> >+    ResourceRequest request;
> >+
> >     gchar* uri;
> >+    WebKitReqCachePolicy cache_policy;
> >+    gdouble timeout_interval;
> >+    gchar* main_document_uri;
> >+    gchar* http_method;
> >+    GHashTable *http_headers;
> >+    gboolean allow_http_cookies;
> >+    gchar *body;
> >+    gsize body_size;
> > };
> 
> You should always use the WebKit style for things that are not exposed in the
> public API.
> 
> Why are you keeping in WebKitNetworkRequestPrivate both the ResourceRequest
> and the values (like cache_policy) that can be easily extracted from it?
> Maybe it makes sense for strings to avoid conversions and duplications
> but not for just integers.

I second that, It makes sense to use members directly, maybe even for strings.

> >+/**
> >+ * webkit_network_request_new:
> >+ * @uri: an already encoded URI
> >+ *
> >+ * Creates a new #WebKitNetworkRequest initialized with an URI.
> >+ *
> >+ * Returns: a new #WebKitNetworkRequest
> >+ */
> > WebKitNetworkRequest* webkit_network_request_new(const gchar* uri)
> 
> Why is this function public? Does it make sense to use it in an application? I
> cannot think to any use case so maybe we could think about deprecating it.

Think of "webkit_web_frame_load_request" here. In that combinaison it seems
like a very powerful interface to me.

> What do you mean with "already encoded URI"?

Scratch "already encoded". If it's an URI, it must be encoded, everything else
is ambiguous. :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.