[Webkit-unassigned] [Bug 20068] adding animation property support to RenderStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20068


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22327|review?(hyatt at apple.com)    |review+
               Flag|                            |




------- Comment #2 from hyatt at apple.com  2008-07-23 13:53 PDT -------
(From update of attachment 22327)
-    setStyle(style);
+    if (style)
+        setStyle(style);

setAnimatableStyle should never be called with a null style.   This smacks of
working around some other problem.  If you have a test case where a null style
was set, then we should be debugging how that happened and stop it rather than
throwing in an unnecessary null check.

I think "Transition" could ultimately be split up into multiple classes (it
seems gross to have all the animation and transition properties together in a
single class that is still called "Transition").  I think this could be done
later though.

Keyframes are all wrong, but I have promised to look the other way for this
initial landing.

EAnimPlayState is only 2 bits so could really be part of the "isSet" bitfield
properties if you moved it to after the keyframe list and made it into:

unsigned m_playState : 2;

(unsigned for Windows compiler's benefit)

That would save a bit of memory.

r=me without making these changes, but I'd like to see the null check removed.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.