[Webkit-unassigned] [Bug 20013] Windows AX huerusitics are poor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20013





------- Comment #4 from jhoneycutt at apple.com  2008-07-22 17:47 PDT -------
Thanks for working on this, Sankar! I am really happy to see you make progress
on this.

I ran into an issue when testing your patch with a change you made to the
roleValue() method:
-    if (node && node->isLink()) {
-        if (m_renderer->isImage())
+       if (node && node->isLink()) {
+        if (isImage())

isImage() calls roleValue(), so this leads to infinite recursion. I think you
meant to use isNativeImage().

Another issue with a change to addChildren():
         } else
+                       obj->setAccessibilityID(childCounter++);
+            obj->setAccessibleParent(this);
             m_children.append(obj);

You are missing braces around those statements, so only the call to
setAccessibilityID() is within the else condition.

With these changes, the accessibility tree on Windows looks much better!
However, I wonder if your work here leads to changes in the accessibility tree
on, for example, the Mac platform. If so, it may be necessary to make some
changes to avoid breaking accessibility on the Mac.

Have you tried running the accessibility layout tests on a Mac after this
patch? None of the accessibility tests will run on Windows currently, but I
believe Sam Weinig is working to add support for this.

As a last note, your ChangeLog entries should explain any non-obvious changes
that have been made to the code. You can look through the other ChangeLog
entries to gain an idea of how verbose they should be.

Again, thanks! I will CC: our cross-platform accessibility engineers and let
them weigh in.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.