[Webkit-unassigned] [Bug 19898] [Gtk] WebKitWebHistoryItem: Fixes and improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19898





------- Comment #7 from webkit at svenfoo.org  2008-07-22 09:18 PDT -------
There are some issues with the documentation changes in this patch though. The
patch introduces documentation like this:

 * Return value: the title of the @webHistoryItem or %NULL if history item
 *               is %NULL. The string is owned by @webHistoryItem and must not
 *               be modified or freed.

It is not allowed to pass NULL for @webHistoryItem though. The changed
documentation of the return value gives the impression that this would be
allowed, but it isn't. There's a g_return_val_if_fail() check for this. It is
correct that this assertion returns NULL. But by definition the behavior is
undefined after such an assertion failed. It will only confuse users of the API
to document this error case.

I very much welcome though that the patch makes it clearer who is responsible
for freeing the returned strings.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.