[Webkit-unassigned] [Bug 20056] [XBL] XBLCachedDocument cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 08:37:20 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=20056


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22309|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2008-07-22 08:37 PDT -------
(From update of attachment 22309)
I think:
5         RefPtr<WebCore::XBLDocument> document() const { return m_document; }

Should probably return PassRefPtr, no?  PassRefPtr will automatically copy from
RefPtr in this case, but there will be no additional ref churn on assignment. 
Otherwise looks fine.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list