[Webkit-unassigned] [Bug 20121] Cleanup of FrameLoader load() in a move towards sanity

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20121


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22399|review?                     |review+
               Flag|                            |




------- Comment #7 from ggaren at apple.com  2008-07-21 14:12 PDT -------
(From update of attachment 22399)
Just to give you some background, all these "load" methods came about when we
merged the loader code, which had been sprinkled throughout WebCore and WebKit,
into a single WebCore class. The merge illuminated a spaghetti-like structure
(perhaps an image of the holy flying spaghetti monster itself?!) of similarly
named and purposed functions. At the time, we named all such functions "load"
as a way of saying, "We should probably refactor this code, removing and/or
merging redundant noodley appendages, when we get a chance."

Anyway, I think your renames improve clarity, so I'll say "r+", but an even
better solution would refactor the loader and eliminate some of these functions
altogether.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.