[Webkit-unassigned] [Bug 20121] New: Cleanup of FrameLoader load() in a move towards sanity

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 20 21:29:12 PDT 2008


           Summary: Cleanup of FrameLoader load() in a move towards sanity
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jalkut at red-sweater.com

I came upon the problem of trying to understand FrameLoader's variety of load()
methods, and made an exercise of annotating/debugging my way to roughly
understanding which methods are used, and under what circumstances.

I renamed many of methods in an effort to increase mental graspability, and
hopefully as a setup for further cleanup iterations. I don't think that the
vast number of overloaded "load()" methods was serving the intended value of
such overloading.  Hopefully the new naming will give a better context for
searching on how the methods are used, and for possibly folding the
functionality further into more logical subroutines.

This patch also includes a couple smaller cleanups which are detailed in the
changelog notes.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list