[Webkit-unassigned] [Bug 20029] [XBL] Add more tags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20029


jchaffraix at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22341|0                           |1
        is obsolete|                            |
  Attachment #22371|                            |review?
               Flag|                            |




------- Comment #12 from jchaffraix at webkit.org  2008-07-18 12:27 PDT -------
Created an attachment (id=22371)
 --> (https://bugs.webkit.org/attachment.cgi?id=22371&action=view)
Patch updated with Eric's comments

(In reply to comment #11)
> (From update of attachment 22341 [edit])
> xblCustomMappings shouldn't be needed.  HTML will need this too.  This should
> just be a property of the tag in the .in file.

I thought it would interact badly with the .in file format change discussed on
the ML that I intend to do (thus my original FIXME). However after thinking
about it, I guess I could add just one property without too much trouble.

> Also, I don't think you need a comment about <div> in the XBLElement header. 
> XBLElements probably want to be StyledElements anyway.  I mean, it's also
> possible to just create an empty XBLDivElement, despite hyatt's suggestions to
> the contrary.  The cost in terms of code and binary size are negligible.

HTMLElement also derives from StyledElement so we could do the same here too.

> I think you should make the "generate w/o having a custom class" thing work
> though, since our first pass in converting HTMLElementFactory will use that.

It should work.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.