[Webkit-unassigned] [Bug 19975] [OpenBSD] Patches to enable build of WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 17 04:59:30 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=19975


landry at fr.homeunix.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22203|0                           |1
        is obsolete|                            |
  Attachment #22246|0                           |1
        is obsolete|                            |
  Attachment #22335|                            |review?
               Flag|                            |




------- Comment #6 from landry at fr.homeunix.org  2008-07-17 04:59 PDT -------
Created an attachment (id=22335)
 --> (https://bugs.webkit.org/attachment.cgi?id=22335&action=view)
patch against svn

And here's a cleaner, simpler patchset against svn, works fine with midori &
webkit-r35203.
ChangeLogs entries are included.
- i finally added a temporary signbit/isfinite implemetation in MathExtras.h,
similar to what is done for Solaris. Once we'll have them in libm it shouldn't
conflict.
- finally, Thread.h patching is not necessary, we have to link with
libstdc++-4.2 anyway (that'll be our only local patch against GNUMakefile.am,
because on openbsd libstdc++ in /usr/lib is 3.3 version, libstdc++ 4.2 is
installed in /usr/local/lib/libestdc++)
- a non-intrusive patch for WebKitTools/DumpRenderTree/DumpRenderTree.h has
been added to conditionally declare the method. I think there's a better way to
handle it, but it compiles and runs fine this way. Having a HAVE_WCHAR
detection could help maybe.
- while here i kept the PLATFORM(SPARC64) definition, needed for the upcoming
fix for alignment problem on sparc64.

I hope this patchset is correct, and am just waiting for a new nightly build
including it to import my port of webkit & midori in OpenBSD's ports-tree. The
fix for sparc64 will be worked on afterwards.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list