[Webkit-unassigned] [Bug 19965] @mediaall recognized as @media all rather than as a generic (unrecognized ATKEYWORD)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19965





------- Comment #13 from jacob.refstrup at hp.com  2008-07-16 08:56 PDT -------
(In reply to comment #11)
> (In reply to comment #6)
> > > Are there no regressions?
> > > 
> > Not sure I follow -- atrule_longest_match.html render correctly before; now it
> > will. I see that I am missing the expected text -- is that what you were
> > referring to?
> 
> Just to be clear, all patches need to go through the run-webkit-tests run
> to check for regressions. See 'Regression tests' here:
> 
> https://www.webkit.org/coding/contributing.html
> 
> What basically is required is that you run the whole suite without your patch,
> note the numer of pass/fails, then apply and build with your patch, rerun the
> suite and note whether anything changed with the pass/fail with the patch. Only
> when the fail count is the same can the patch be accepted.
> Cheers,
> 
> Rob.
> 

Thanks for the followup Rob -- it does pass in the sense no new or different
errors were reported in regression against Qt and Gtk.

- Jacob


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.