[Webkit-unassigned] [Bug 19965] @mediaall recognized as @media all rather than as a generic (unrecognized ATKEYWORD)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 01:44:33 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=19965





------- Comment #11 from rwlbuis at gmail.com  2008-07-16 01:44 PDT -------
(In reply to comment #6)
> > Are there no regressions?
> > 
> Not sure I follow -- atrule_longest_match.html render correctly before; now it
> will. I see that I am missing the expected text -- is that what you were
> referring to?

Just to be clear, all patches need to go through the run-webkit-tests run
to check for regressions. See 'Regression tests' here:

https://www.webkit.org/coding/contributing.html

What basically is required is that you run the whole suite without your patch,
note the numer of pass/fails, then apply and build with your patch, rerun the
suite and note whether anything changed with the pass/fail with the patch. Only
when the fail count is the same can the patch be accepted.
Cheers,

Rob.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list