[Webkit-unassigned] [Bug 20007] New: Signature of WebView::select-all differs from TextView::select-all

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20007

           Summary: Signature of WebView::select-all differs from
                    TextView::select-all
           Product: WebKit
           Version: 526+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: Gtk
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: christian at imendio.com


WebKitWebView has an action signal "select-all" that when called selects
everything in the current page. The signature is this:

void select-all (WebKitWebView* web_view, gpointer user_data)

By comparison, GtkTextView has the same signal, but with a different signature:

void select-all (GtkTextView* text_view, gboolean select, gpointer user_data)

If the boolean "select" is TRUE, everything is selected, which is what WebView
currently does. But if it is FALSE, everything is unselected. It is actually
possible to call "select-all" without a boolean on a TextView but the behaviour
is the reverse of what WebView does.

I think we should really fix the signature of WebView to match TextView. I
think it's not probable that it breaks anything because I don't think that one
usually connects a callback to that signal.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.