[Webkit-unassigned] [Bug 19954] Element with -webkit-mask: -webkit-canvas() is not redrawn when the canvas updates

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 9 13:12:04 PDT 2008


hyatt at apple.com changed:

           What    |Removed                     |Added
  Attachment #22167|review?                     |review-
               Flag|                            |

------- Comment #4 from hyatt at apple.com  2008-07-09 13:12 PDT -------
(From update of attachment 22167)
(1) Adding maskBoxImage to RenderBox's first check is good.

(2) Adding maskImage is bad.  We want precise invalidation like we have  with
backgrounds.  See the layer walk at the end of the function.  You should make a
little static helper function that walks layers to do the invalidation.  Then
you can call it on the background layers and on the mask layers.

(2) The patch to RenderImage should just call the base class if you have a
mask.  So changing if (hasBoxDecorations()) to if (hasBoxDecorations() ||
hasMask()) should be sufficient.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list