[Webkit-unassigned] [Bug 19963] New: "$OpenBSD$" markers display in PrettyPatch, but not built-in "diff"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 9 11:17:18 PDT 2008


https://bugs.webkit.org/show_bug.cgi?id=19963

           Summary: "$OpenBSD$" markers display in PrettyPatch, but not
                    built-in "diff"
           Product: WebKit
           Version: 525.x (Safari 3.1)
          Platform: All
               URL: https://bugs.webkit.org/attachment.cgi?id=22185&action=p
                    rettypatch
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: aroben at apple.com


* SUMMARY
An OpenBSD patch on Bug 19775 uses "$OpenBSD$" as a marker between file diffs. 
The built-in "diff" format on bugs.webkit.org does not display these lines:

https://bugs.webkit.org/attachment.cgi?id=22185&action=diff

However, PrettyPatch does display them (after skipping the first) at the end of
each diff:

https://bugs.webkit.org/attachment.cgi?id=22185&action=prettypatch

I think counting the number of actual/expected lines in the patch while parsing
out individual diffs may fix the issue.  (Would be interesting to look at how
the "diff" format does its parsing, too.)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list