[Webkit-unassigned] [Bug 19933] nodeIterator with filter fails on documents not in a frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19933


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22145|review?                     |review+
               Flag|                            |




------- Comment #6 from darin at apple.com  2008-07-07 17:14 PDT -------
(From update of attachment 22145)
     /* exec should only be null when calling from a non-JavaScript language to
        a JavaScript filter, when the document in question is not associated
        with a frame
     */

We normally use "//" comments, not "/*". I also would prefer that the comment
be a sentence with a capital letter and period. Here's my suggested wording:

    // The exec argument here should only be null if this was called from a
    // non-JavaScript language, and this is a JavaScript filter, and the
document
    // in question is not associated with the frame. In that case, we're going
to
    // behave incorrectly, and just reject nodes instead of calling the filter
function.
    // To fix that we'd need to come up with a way to find a suitable
JavaScript
    // execution context for the filter function to run in.

I know that's pretty wordy, sorry.

    /* static */
    ExecState* NodeFilter::execStateFromNode(Node* node)

We don't normally add a comment like this before a static member function.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.