[Webkit-unassigned] [Bug 19911] :read-only and :read-write pseudoclasses support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 7 10:02:35 PDT 2008


adele at apple.com changed:

           What    |Removed                     |Added
  Attachment #22107|review?(adele at apple.com)    |review-
               Flag|                            |

------- Comment #3 from adele at apple.com  2008-07-07 10:02 PDT -------
(From update of attachment 22107)
Looks pretty good- I have just a few comments:

atomic strings in CSSSelector.cpp should be readOnly and readWrite

you shouldn't need the check  && !e->isInputTypeHidden()

you've left out checks for search fields and isindex - instead of using the
specific checks for the type, you can use isTextField().

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list