[Webkit-unassigned] [Bug 13067] Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13067


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22108|review?                     |review+
               Flag|                            |




------- Comment #9 from darin at apple.com  2008-07-06 19:26 PDT -------
(From update of attachment 22108)
         checkNavigationPolicy(request, oldDocumentLoader.get(), formState,
-            callContinueFragmentScrollAfterNavigationPolicy, this);
+                              callContinueFragmentScrollAfterNavigationPolicy,
this);

I don't personally consider this indentation change an improvement. It's a
change from a form that can be done with a simple editor to a form that
requires careful indenting or a syntax-sensitive editor (like emacs).

+    // These rules are based on what KHTML was doing in KHTMLPart::openURL.

I think this comment should either go away or change its wording to "were
originally based on".

+        bool shouldScrollToAnchor(bool isFormSubmission, FrameLoadType
newLoadType, const KURL& newURL);

I'm not sure the "new" prefix alone is enough to justify giving the argument
names here.

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.