[Webkit-unassigned] [Bug 19130] [GTK] ChromeClient::createWindow and friends need to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19130





------- Comment #25 from gns at gnome.org  2008-07-06 16:26 PDT -------
(In reply to comment #23) 
> I tested the patch a bit more, I found that clicking on open in new window in
> the context menu opens a new windows but doesn't navigate there. I didn't
> investigate the reason yet, I wonder if this goes through yet another code
> path.

It did work on my test with midori. Also, I put some printf's in WebCore's code
and found that open in new window goes this way:

WebCore/page/ContextMenuController.cpp:openNewWindow

which calls

WebCore/page/Chrome.cpp:Chrome::createWindow

which then calls

WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:ChromeClient::createWindow

javascript's window.open calls ChromeClient's createWindow through another code
path, and target="_blank" links opens new windows in Midori with Christian's
patch, but does not go through that code path at all; I'll try to find what
path it takes


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.