[Webkit-unassigned] [Bug 19130] [GTK] ChromeClient::createWindow and friends need to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19130





------- Comment #24 from christian at imendio.com  2008-07-01 14:03 PDT -------
(In reply to comment #23)
> At this point maybe it's better to just remove the show-web-view signal.

I think I agree here. Right now the use case is rather unclear. Unless... see
above:

> I tested the patch a bit more, I found that clicking on open in new window in
> the context menu opens a new windows but doesn't navigate there. I didn't
> investigate the reason yet, I wonder if this goes through yet another code
> path.

This might be the only reason why show-web-view exists, if in this case it was
meant to activate the new window/ tab? Or it might as well be nonsense, I did
not investigate that idea yet. Marco, did you by chance try to hook
show-web-view up to see if it makes a difference?

> Note that we are passing a network request to new-web-view but other
> ports just pass the URL.

I wonder if there was a reason besides simplicity of api. Imho it's quite a lot
more flexible with a network request, including possible future enhancements.

> Any suggestion on the locationbar/uribar/uri_entry naming?

Traditionally locationbar was actually a separate toolbar, unlike today where
most navigators include a location entry in the main toolbar. So I think we
should keep that name.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.