[Webkit-unassigned] [Bug 19954] Element with -webkit-mask: -webkit-canvas() is not redrawn when the canvas updates
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 9 15:40:25 PDT 2008
https://bugs.webkit.org/show_bug.cgi?id=19954
simon.fraser at apple.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #22167|0 |1
is obsolete| |
Attachment #22191| |review?
Flag| |
------- Comment #5 from simon.fraser at apple.com 2008-07-09 15:40 PDT -------
Created an attachment (id=22191)
--> (https://bugs.webkit.org/attachment.cgi?id=22191&action=view)
Patch addressing review comments
> (1) Adding maskBoxImage to RenderBox's first check is good.
I didn't add that, I just unwrapped the line.
> (2) Adding maskImage is bad. We want precise invalidation like we have with
> backgrounds. See the layer walk at the end of the function. You should make a
> little static helper function that walks layers to do the invalidation. Then
> you can call it on the background layers and on the mask layers.
Done. Note that I had to add FillLayer::containsWrappedImage().
I added a method, repaintLayerRectsForImage(), rather than a static method,
because
it needs to get at the view() for invalidation.
> (2) The patch to RenderImage should just call the base class if you have a
> mask. So changing if (hasBoxDecorations()) to if (hasBoxDecorations() ||
> hasMask()) should be sufficient.
Done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list